Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Renames the minumumSizeHint method to minimumSizeHint#28732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Thanks for the PR! I think since this is public API, it technically needs a deprecation period? Since the function is being renamed? Which is technically a kinda removal I think?https://matplotlib.org/devdocs/devel/api_changes.html#deprecate-api Here I think we can get away with aliasing the old name to the new one and deprecating there, but unsure? |
No, this should not have a deprecation. This is a Qt API:https://doc.qt.io/qt-6/qwidget.html#minimumSizeHint-prop Qt calls this to determine the size. With the typo the function was basically unused. No user should have called this. |
9fd2ef9 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…732-on-v3.9.xBackport PR#28732 on branch v3.9.x (Renames the minumumSizeHint method to minimumSizeHint)
PR summary
PR checklist