Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Stop disabling FH4 Exception Handling on MSVC#28725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromQuLogic:enable-fh4
Aug 15, 2024

Conversation

QuLogic
Copy link
Member

PR summary

As of#28687, our extensions depend onVCRUNTIME140_1.dll, and this was allowed because Python 3.8+ started shipping that file. The original report in#18292 was for Python 3.7, which didn't ship the DLL, but we require Python 3.10 now, so it's safe again.

Since we can use that dependency, there's no need to disable the option that started requiring it in the first place. As noted in the original blog post [1], this will make our extensions smaller, and slightly faster.

[1]https://devblogs.microsoft.com/cppblog/making-cpp-exception-handling-smaller-x64/

PR checklist

As ofmatplotlib#28687, our extensions depend on `VCRUNTIME140_1.dll`, and thiswas allowed because Python 3.8+ started shipping that file. The originalreport inmatplotlib#18292 was for Python 3.7, which didn't ship the DLL, but werequire Python 3.10 now, so it's safe again.Since we can use that dependency, there's no need to disable the optionthat started requiring it in the first place. As noted in the originalblog post [1], this will make our extensions smaller, and slightlyfaster.[1]https://devblogs.microsoft.com/cppblog/making-cpp-exception-handling-smaller-x64/
@QuLogicQuLogic added this to thev3.10.0 milestoneAug 15, 2024
@QuLogicQuLogic added the CI: Run cibuildwheelRun wheel building tests on a PR labelAug 15, 2024
@timhoffmtimhoffm merged commit699dd7e intomatplotlib:mainAug 15, 2024
47 of 51 checks passed
@QuLogicQuLogic deleted the enable-fh4 branchAugust 15, 2024 05:19
@QuLogicQuLogic mentioned this pull requestAug 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PROS: Microsoft
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp