Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MEP27 Part1: WindowGTK, Refactoring the FigureManagerGTK classes#28699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
OceanWolf wants to merge1 commit intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…tor, splitting up previous PRs into smaller easier to review chunks.
b86ebb1 to9647197CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR exists as Part 1 of an attempt to resolve MEP 27 by splitting my previous PR (#4143) into smaller, more manageable, and thus easier to review chunks. Whilst my previous PR focussed solely on GTK3, this PR focuses solely on the windowing aspect of GTK3/4 with the rest of GTK3/4 refactor and MEP 27 infrastructure to follow in future PRs. Each of the other backends will then have the additional classes added in one PR per backend (~300 lines of code) This MEP has the ultimate goal of deprecating
FigureManagerBaseand all of its subclasses, in favour of a single GUI agnosticFigureManagerclass, similar to whatFigureManagerGTKlooks like in this PR.The Window API of MEP27, implemented here, allows for the possibility for (multiple) toolbars to get placed along any edge of the window. I had written an example in my previous PR, but I have left that for a future PR, but can also easily get added here (~50 lines of code)
This PR has mainly been a copy/paste from my previous PR, but for: the addition of GTK4 which was released in the meantime; and taking into account other changes that have occurred in the MPL GTK codebase since then. In doing so, I have taken the opportunity to clean the codebase with respect to the differences between GTK3 and GTK4.
PR checklist