Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix warnings from mingw compilers#28682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Looking at pybind11 again, the `py::capsule::name` method returns a`const char *`, and comparing that with a literal using `==` isunspecified behaviour. Seemingly, this is fine on MSVC, but MinGW gccwarns about it.
This warns with MinGW, since it already defines `_WIN32_WINNT` to0x0a00.
oscargus approved these changesAug 8, 2024
1de8208 intomatplotlib:main 45 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 8, 2024
greglucas added a commit that referenced this pull requestAug 8, 2024
…682-on-v3.9.xBackport PR#28682 on branch v3.9.x (Fix warnings from mingw compilers)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This fixes severalwarnings I noticed while debugging source builds for#28551.
Most are harmless, but I think the capsule change in
_c_internal_utilsmay have hidden a real error (and possibly MSVC just "did the right thing" for us).PR checklist