Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Closed open div tag in color.ColorMap._repr_html_#28634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I saw the same change go by in I think#28454 , but it makes sense to get this in on its own more quickly than we will sort out the multivariate colormap work.
5c87b78 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…634-on-v3.9.xBackport PR#28634 on branch v3.9.x (Closed open div tag in color.ColorMap._repr_html_)
Thank you for your work on this@pirsquared and congratulations on (I think) your first merged PR to Matplotlib 🎉 I hope we hear from you agian! |
PR summary
ColorMap.repr_html produces html that doesn't properly close all div tags. It was simple fix to add a closing div to the method.