Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
CI: Add CI to test matplotlib against free-threaded Python#28610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Tests are passing now! |
I do have a slight concern that this has significant copy-paste from the rest of our tests, but I also see an argument that this is easier to deal with than adding conditionals to the existing test ymls. |
@tacaswell I 100% agree with your assessment, however, as this new file could disappear once there are proper wheels for all the upstream dependencies (after Python 3.13 release), it can be used to set potential individual tweaks for future free-threaded releases. |
@tacaswell I think this PR is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please fix the linting issue ? |
| uses: deadsnakes/action@6c8b9b82fe0b4344f4b98f2775fcc395df45e494 # v3.1.0 | ||
| with: | ||
| python-version: "3.13" | ||
| nogil: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| uses:deadsnakes/action@6c8b9b82fe0b4344f4b98f2775fcc395df45e494# v3.1.0 | |
| with: | |
| python-version:"3.13" | |
| nogil:true | |
| uses:deadsnakes/action@6c8b9b82fe0b4344f4b98f2775fcc395df45e494# v3.1.0 | |
| with: | |
| python-version:"3.13" | |
| nogil:true |
In addition, the whole file should be dedented by 4 spaces (aside from the first line which has no spaces)
Thanks for the PR! I have rolled all these changes into#28689. |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
See#28611
This PR enables testing matplotlib against free-threaded Python, this is part of the ongoing effort to test projects against the changes proposed inPEP703
For more information see the following related PRs in other projects:
PR checklist