Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix subprocess.CalledProcessError on Google App Engine#2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:v1.3.xfromdaradib:subprocess-google-app-engine
Mar 8, 2014
Merged

Fix subprocess.CalledProcessError on Google App Engine#2860

tacaswell merged 1 commit intomatplotlib:v1.3.xfromdaradib:subprocess-google-app-engine
Mar 8, 2014

Conversation

daradib
Copy link
Contributor

Small bugfix for 1.3.x that sets subprocess.CalledProcessError to None on restrictive environments like Google App Engine.Fixes#1825 which broke after#1857.

Set subprocess.CalledProcessError to None on restrictive environmentslike Google App Engine because the exception cannot be raised and thereis no need to catch it.Fixes#1825 which broke after#1857.
@mdboom
Copy link
Member

👍 Thanks. Looks good, assuming Travis-CI agrees with me ;)

@tacaswell
Copy link
Member

Is there a way to convince travis to run in a restricted environment which mocks GAE?

@mgiuca-google Is it possible to get google to throw some cycles at testing on GAE on a semi-regular basis?

@daradib
Copy link
ContributorAuthor

@tacaswell You could download and run the GAE SDK in Travis (underbefore_script in.travis.yml). But right now it needs to be manually modified to use matplotlib in the dev web server bundled with the SDK.@mgiuca-google listed the changes#1823 (not sure if all of it is still necessary with the latest SDK).

Will Google support matplotlib without changes to the SDK in the future?

@mgiuca-google
Copy link
Contributor

Hi all. Sorry, I haven't been keeping up with matplotlib on GAE as I am no longer on the GAE team at Google. I can contact the team if you have any specific requirements.

Testing on the dev appserver should give a reasonably good approximation of the real environment, but (as with everything on GAE), there is no substitute for testing on production. Unfortunately, because mpl has C code, there is no way for an external user to run a new version of it on GAE production. You would have to wait for Google engineers to pull the latest version.

@mgiuca-google Is it possible to get google to throw some cycles at testing on GAE on a semi-regular basis?

The Matplotlib test suite is already part of the GAE test suite, so we will never upgrade to a new version of mpl without first ensuring that all the tests pass. But of course, we test the current version of mpl listedhere (at the time of writing, 1.2.0), and I assume you're asking about testing against git HEAD. I think it would be prohibitive for us to set up some automated tests against HEAD (given that there is manual work involved in updating to a new version of matplotlib on GAE). I guess I'm not sure what you want out of this --- is it just ensuring that matplotlib will not break when we get around to updating it on GAE? I guess that since you have no real way of knowing whether it will break on GAE, that's our responsibility when we get around to pulling a new version.

Will Google support matplotlib without changes to the SDK in the future?

That was always the plan. However, since I haven't been maintaining it, I'm not sure if anyone has fixed the dev appserver to run Matplotlib without modifications.

@tacaswell
Copy link
Member

@mgiuca-google That addresses my concerns (I am not super familiar with GAE). I had not fully grasped that the users don't get to install what ever version they want. If there will always be a human at google involved in upgrading the available version on GAE and the test suite gets run that is about the best we can do. It would be nice if we could get the feed back sooner rather than later (and you updated your mpl version more often ;)), but oh well.

@tacaswelltacaswell modified the milestones:v1.4.0,v1.3.xMar 4, 2014
tacaswell added a commit that referenced this pull requestMar 8, 2014
Fix subprocess.CalledProcessError on Google App Engine
@tacaswelltacaswell merged commita7d9266 intomatplotlib:v1.3.xMar 8, 2014
@daradibdaradib deleted the subprocess-google-app-engine branchApril 1, 2014 23:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.x
Development

Successfully merging this pull request may close these issues.

4 participants
@daradib@mdboom@tacaswell@mgiuca-google

[8]ページ先頭

©2009-2025 Movatter.jp