Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: make sticky edge tolerance relative to data range#28582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ksunden approved these changesJul 17, 2024
jklymak approved these changesJul 17, 2024
0da7d89 intomatplotlib:main 38 of 40 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 17, 2024
oscargus added a commit that referenced this pull requestJul 17, 2024
…582-on-v3.9.xBackport PR#28582 on branch v3.9.x (FIX: make sticky edge tolerance relative to data range)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
PR: bugfixPull requests that fix identified bugs Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: axes
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes#28567, by applying the suggestion from#28393 (comment) to make the sticky edge tolerance only relative to the data range, rather than the maximum of the range and absolute values. Also revert the main code change from#28393 as both changes are not needed to achieve that fix.
Marking "release critical" since downstream tests broke.
PR checklist