[N/A] "closes #0000" is in the body of the PR description tolink the related issue
[N/A] new and changed code istested
[N/A]Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

github-actionsbot added the Documentation: examplesfiles in galleries/examples label

Jul 13, 2024

github-actionsbot reviewed

Jul 13, 2024

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

QuLogic reviewed

Jul 13, 2024

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please also fix the linting error.

galleries/examples/mplot3d/2dcollections3d.py OutdatedShow resolvedHide resolved

Copy link

Member

QuLogic commentedJul 14, 2024

Sorry, I missed it earlier, but every tag list should be comma-separated.

scottshambaugh added the topic: mplot3d label

Jul 15, 2024

story645 added mentored: sprint

Issues intended and suitable for sprints

Documentation: tagstagging examples + proposing new tags labels

Jul 19, 2024

story645 reviewed

Jul 23, 2024

View reviewed changes

Copy link

Member

story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, sorry it took so long to review this. Reviews are mostly fixing formatting - please let me know if you plan to finish this out or if someone should take over. Thanks!

galleries/examples/mplot3d/custom_shaded_3d_surface.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/bars3d.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/contour3d_3.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/contourf3d.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/contourf3d_2.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/surface3d_3.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/surface3d_radial.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/tricontour3d.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/trisurf3d_2.py OutdatedShow resolvedHide resolved

galleries/examples/mplot3d/view_planes_3d.py OutdatedShow resolvedHide resolved

scottshambaugh added the status: needs revision label

Aug 10, 2024

Copy link

Author

farquh commentedSep 1, 2024

Hi, sorry it took so long to review this. Reviews are mostly fixing formatting - please let me know if you plan to finish this out or if someone should take over. Thanks!

Sorry I missed this and also didn't respond for awhile. Someone else should probably take over. Thank you!

Copy link

Member

rcomer commentedSep 1, 2024

Someone else should probably take over.

Thanks for letting us know@farquh!

rcomer added the status: orphaned PR label

Sep 1, 2024

added tags to mplot3dexamples

f5abe2c

QuLogic force-pushed the'tagging_mplot3d' branch from214bbbf tof5abe2cCompare

September 14, 2024 09:45

github-actionsbot removed the topic: mplot3d label

Sep 14, 2024

QuLogic added topic: mplot3d and removed status: orphaned PR labels

Sep 14, 2024

QuLogic added this to thev3.10.0 milestone

Sep 14, 2024

Copy link

Member

QuLogic commentedSep 14, 2024

I rebased and took care of the issues with the tags.

story645 removed the status: needs revision label

Sep 15, 2024

scottshambaugh approved these changes

Oct 16, 2024

View reviewed changes

scottshambaugh merged commit3c7bc45 intomatplotlib:main

Oct 16, 2024

28 checks passed

Copy link

Contributor

scottshambaugh commentedOct 16, 2024

Thank you@farquh for your work on this - it will be part of the upcoming v3.10 release. Congratulations on your first contribution to matplotlib, and we hope to see you again!