Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: improve tagging guidelines page#28527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 3 commits intomatplotlib:mainfromstory645:tag-guide
Jul 11, 2024

Conversation

story645
Copy link
Member

Based on discussions w/ @esibing after#27235 and so it's improved for scipy sprints, cleaned up the tagging page so:

  • list of categories pulls from glossary section headings so will remain in sync
  • added a code example of how to add tags
  • move content guidelines to writing guide -> I don't want/expect it to stay there, but think it's distracting here.

Also, thanks to@melissawm andmelissawm/sphinx-tags#102

  • enable multiline

PR summary

PR checklist

melissawm reacted with hooray emoji
@story645story645 added Documentation: devdocsfiles in doc/devel Documentation: tagstagging examples + proposing new tags labelsJul 9, 2024
@story645story645force-pushed thetag-guide branch 2 times, most recently from37587bf to502fb6bCompareJuly 9, 2024 21:13
@story645
Copy link
MemberAuthor

Attempted to address all the comments

Copy link
Member

@timhoffmtimhoffm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Take or leave my comments. You can self-merge after that (and fixing the sphinx build).

story645 reacted with thumbs up emoji

All :ref:`examples-index` should aim to follow these guidelines:

:Title: Describe content in a short sentence (approx. 1-6 words). Do not use *demo* as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does sentence imply a full sentence including verb? Possible alternatives: expression, phrase ... (not a native speaker so cannot really judge)

story645and others added3 commitsJuly 11, 2024 05:12
add coding examplemove content guidelines to writing guideenable multilineCo-authored-by: Eva Sibinga <46283995+esibinga@users.noreply.github.com>Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@story645story645 merged commit48c8f07 intomatplotlib:mainJul 11, 2024
44 checks passed
@story645
Copy link
MemberAuthor

story645 commentedJul 11, 2024•
edited
Loading

Thanks, self merged after addressing the comments so this would be live for when we advertise tagging next session, but will totally make a follow up if anyone has feedback.

timhoffm reacted with thumbs up emoji

@QuLogicQuLogic added this to thev3.10.0 milestoneJul 12, 2024
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestJul 12, 2024
Following recommendatinos frommatplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestJul 27, 2024
Following recommendatinos frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw at aglance when going through the examples once. Certainly, one could dofurther improvements, but that can be done in follow-ups.Co-authored-by: hannah <story645@gmail.com>
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestAug 1, 2024
Follow up tomatplotlib#28544. As there:Following recommendations frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestAug 1, 2024
Follow up tomatplotlib#28544. As there:Following recommendations frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestAug 1, 2024
Follow up tomatplotlib#28544. As there:Following recommendations frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestAug 1, 2024
Follow up tomatplotlib#28544. As there:Following recommendations frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestAug 2, 2024
Follow up tomatplotlib#28544. As there:Following recommendations frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestAug 2, 2024
Follow up tomatplotlib#28544. As there:Following recommendations frommatplotlib#28527, this improves example titles.Take this as an incremental improvement. I've changed what I saw  t aglance when going through the examples once. Certainly, one could dofurther improvements, but that can be done in follow-ups.Co-authored-by: hannah <story645@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: buildbuilding the docsDocumentation: devdocsfiles in doc/develDocumentation: tagstagging examples + proposing new tags
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

3 participants
@story645@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp