Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump minimum Python to 3.10#28503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromQuLogic:py310
Jul 13, 2024
Merged

Bump minimum Python to 3.10#28503

ksunden merged 1 commit intomatplotlib:mainfromQuLogic:py310
Jul 13, 2024

Conversation

QuLogic
Copy link
Member

PR summary

It's time for this by SPEC0, and our nightly build has started failing since Pandas has already dropped 3.9 support.

Fixes#28489

Draft because I need to see if I got the minimum Qt dependencies right.

PR checklist

@QuLogic
Copy link
MemberAuthor

It looks like we have problems building on PyPy3.10 because NumPy doesn't have wheels yetnumpy/numpy#26141

Also, not sure if the original test condition on the ipynb test is wrong, since it's failing here.

@tacaswell
Copy link
Member

I think we just skip pypy310 on at least windows, maybe all platforms.

@QuLogic
Copy link
MemberAuthor

I added aipykernel==5.5.6 requirement to the older ipython job, as pip was walking back the versions to find a compatible one, so probably best to help it along with a pin.

However,test_ipynb is failing, and it seems like we are gettingmodule://ipykernel.pylab.backend_inline instead of our expectedmodule://ipykernel.pylab.backend_inline, and I'm not sure why it's only happening now with Python 3.10 instead of the older 3.9, but I can reproduce locally. cc@ianthomas23

@ianthomas23
Copy link
Member

I think your ipython pin should be 7.29.0 as that was released in October 2021, the same month as Python 3.10. That is consistent with ipykernel 5.5.6. The test passes locally for me using these.

@QuLogic
Copy link
MemberAuthor

I forgot about Cygwin here; I believe they only have 3.9, and the plan is to jump to 3.12 directly:numpy/numpy#26222 (comment)

We'll have to disable it in the meantime.

@github-actionsgithub-actionsbot added the CI: Run cygwinRun cygwin tests on a PR labelJul 5, 2024
@QuLogicQuLogic marked this pull request as ready for reviewJuly 5, 2024 22:08
@rcomer
Copy link
Member

Could we also add a minimum pin for python inenvironment.yml? For some reason mamba gives me 3.9 by default, but it also resolves fine if I pin it higher.

if: >-
github.event_name == 'workflow_dispatch' ||
github.event_name == 'schedule' ||
(false &&github.event_name == 'schedule') ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did you mean to keep thefalse here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

answer: yes, cygwin is skipping 3.10 and 3.11, but is not ready for 3.12, so will be re-enabled later

@ksundenksunden merged commitdc64946 intomatplotlib:mainJul 13, 2024
40 of 42 checks passed
@QuLogicQuLogic deleted the py310 branchJuly 13, 2024 23:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PRCI: Run cygwinRun cygwin tests on a PRDocumentation: devdocsfiles in doc/develDocumentation: user guidefiles in galleries/users_explain or doc/userstopic: sankeytopic: stylestopic: ticks axis labels
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
5 participants
@QuLogic@tacaswell@ianthomas23@rcomer@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp