Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix CompositeGenericTransform.contains_branch_seperately#28486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Formerly, this fell back to the the super-class Transformimplementation, which returned `Transform.contains_branch` for bothdimensions. This doesn't make sense for blended transforms, which havetheir own implementation that checks each side. However, it _also_doesn't make sense for composite transforms, because those may containblended transforms themselves, so add a specific implementation for it.Also fix type inconsistency for `Transform.contains_branch_seperately`.
ksunden approved these changesJun 28, 2024
greglucas approved these changesJun 29, 2024
00cbd9c intomatplotlib:main 47 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 29, 2024
ksunden added a commit that referenced this pull requestJul 1, 2024
…486-on-v3.9.xBackport PR#28486 on branch v3.9.x (Fix CompositeGenericTransform.contains_branch_seperately)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Formerly, this fell back to the the super-class Transform implementation, which returned
Transform.contains_branchfor both dimensions. This doesn't make sense for blended transforms, which have their own implementation that checks each side. However, italso doesn't make sense for composite transforms, because those may contain blended transforms themselves, so add a specific implementation for it.Also fix type inconsistency for
Transform.contains_branch_seperately.This doesfix#28383, though since it has to reach into transform internals to do so might make one a bit wary.
PR checklist