Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Do not lowercase module:// backends#28473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesJun 27, 2024
QuLogic approved these changesJun 27, 2024
b94f1ce intomatplotlib:main 48 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 27, 2024
QuLogic added a commit that referenced this pull requestJun 28, 2024
…473-on-v3.9.xBackport PR#28473 on branch v3.9.x (Do not lowercase module:// backends)
Corresponding change in IPython isipython/ipython#14475. |
Carreau added a commit to ipython/ipython that referenced this pull requestAug 30, 2024
This is something I missed as part of moving the backend resolution toMatplotlib. Since version 3.9.0 Matplotlib handles the case-sensitivityof backend names, making them all lowercase for internal use. But sincematplotlib/matplotlib#28473 uppercase letters are allowed in backendnames of the form `module://soMe_moDule.sOmE_NAme`. Hence we need to notforce backend names to be lowercase in IPython when passing them toMatplotlib. It is just a one line change that happens to make the codesimpler, plus a new test.The Matplotlib change will be released in 3.9.1 which is due shortly,possibly today. The new test checks the Matplotlib version to knowwhether uppercase backend module names are allowed or not.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#28432
PR summary
This adds checks to avoid changing cases of
module://names.Entry point names and default names will still be normalized.
Adds a test to ensure loading is case sensitive as well as a unit test of the normalization function (which is private, but fairly central)
PR checklist