Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix GTK cairo backends#28451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix GTK cairo backends#28451
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
With GTK4, the Cairo context we get is always in logical pixels, and isautomatically scaled to the right size, without any worry aboutblurriness. So in that case, we can ignore all scale factor changes, andassume it's always 1.The remaining effect of tracking scale factor changes is to trigger are-draw, but GTK will send a resize event to go along with it, whichwill do that for us.Fixesmatplotlib#25847Replacesmatplotlib#25861
With GTK3, the Cairo surface we get is for the whole window, which meansthe automatic size inference frommatplotlib#22004 gets the wrong size. For theGtkDrawingArea, the Cairo context is aligned and clipped to the widget,so nothing goes out-of-bounds. However, since the Cairo renderer flipsthe origin using the height in the calculation (which is, for thewindow, bigger than the drawing widget), everything is drawn lower thanit should.
tacaswell approved these changesJul 3, 2024
0ad8ee1
intomatplotlib:main 51 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 3, 2024
QuLogic added a commit that referenced this pull requestJul 4, 2024
…451-on-v3.9.xBackport PR#28451 on branch v3.9.x (Fix GTK cairo backends)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
For GTK4Cairo, HiDPI displays were broken because we were scaling unnecessarily, as GTK4 takes care of setting up the Cairo context for us with the right scale.
For GTK3Cairo,all displays were broken, as we inferred the size from the backing surface (since#22004), which is the size of thewindow. Then we re-orient the origin using that height, causing everything to be placed incorrectly.
PR checklist