Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix GTK cairo backends#28451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 2 commits intomatplotlib:mainfromQuLogic:gtk-cairo-hidpi
Jul 3, 2024
Merged

Conversation

QuLogic
Copy link
Member

PR summary

For GTK4Cairo, HiDPI displays were broken because we were scaling unnecessarily, as GTK4 takes care of setting up the Cairo context for us with the right scale.

For GTK3Cairo,all displays were broken, as we inferred the size from the backing surface (since#22004), which is the size of thewindow. Then we re-orient the origin using that height, causing everything to be placed incorrectly.

PR checklist

With GTK4, the Cairo context we get is always in logical pixels, and isautomatically scaled to the right size, without any worry aboutblurriness. So in that case, we can ignore all scale factor changes, andassume it's always 1.The remaining effect of tracking scale factor changes is to trigger are-draw, but GTK will send a resize event to go along with it, whichwill do that for us.Fixesmatplotlib#25847Replacesmatplotlib#25861
With GTK3, the Cairo surface we get is for the whole window, which meansthe automatic size inference frommatplotlib#22004 gets the wrong size. For theGtkDrawingArea, the Cairo context is aligned and clipped to the widget,so nothing goes out-of-bounds. However, since the Cairo renderer flipsthe origin using the height in the calculation (which is, for thewindow, bigger than the drawing widget), everything is drawn lower thanit should.
@ksundenksunden merged commit0ad8ee1 intomatplotlib:mainJul 3, 2024
51 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 3, 2024
@ksundenksunden mentioned this pull requestJul 3, 2024
2 tasks
@QuLogicQuLogic deleted the gtk-cairo-hidpi branchJuly 3, 2024 20:11
QuLogic added a commit that referenced this pull requestJul 4, 2024
…451-on-v3.9.xBackport PR#28451 on branch v3.9.x (Fix GTK cairo backends)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp