Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Update basic units example to work with numpy 2.0#28441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There are new keyword arguments required for __array__ and__array_wrap__ that are expected in numpy 2.0.
story645 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is probably overly complicated as a "how to make units" example, but also thanks for fixing this.
Can merge on tests passing.
e243b2c
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
@meeseeksdev backport to v3.9.x |
…441-on-v3.9.xBackport PR#28441 on branch v3.9.x (MNT: Update basic units example to work with numpy 2.0)
PR summary
We are getting reviewdog failures in the galleries/examples tests with numpy 2.0. There are new keyword arguments required forarray andarray_wrap that are expected in numpy 2.0.
From the release noteshttps://numpy.org/devdocs/release/2.0.0-notes.html
https://numpy.org/devdocs/release/2.0.0-notes.html#the-array-special-method-now-takes-a-copy-keyword-argument
PR checklist