Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix pickling of AxesWidgets.#28430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 5 commits intomatplotlib:mainfromanntzer:pw
Jul 4, 2024
Merged

Fix pickling of AxesWidgets.#28430

QuLogic merged 5 commits intomatplotlib:mainfromanntzer:pw
Jul 4, 2024

Conversation

anntzer
Copy link
Contributor

There's no need to hold onto the (non-picklable) canvas as an attribute.

Closes#22482.

PR summary

PR checklist

@anntzeranntzer added topic: widgets/UI topic: pickleIssues to do with pickling labelsJun 20, 2024
@QuLogicQuLogic added this to thev3.9.1 milestoneJun 26, 2024
ksunden
ksunden previously approved these changesJun 26, 2024
@ksundenksunden dismissed theirstale reviewJune 26, 2024 19:45

SpanSelector sets thecanvas attrubute in__init__, which fails because it is readonly now

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This apparently breaksSpanSelector.

@tacaswell
Copy link
Member

This is also going to break_changed_canvas which we use to suppress events durring saving (see#25085 /6bb208d )

@anntzeranntzerforce-pushed thepw branch 2 times, most recently from31be678 tof13e212CompareJune 26, 2024 22:00
There's no need to hold onto the (non-picklable) canvas as an attribute.
@anntzer
Copy link
ContributorAuthor

Now fixed; the test failure is unrelated.

@ksunden
Copy link
Member

Test failure is not unrelated, it is the newly added test

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anyone can merge on CI finishing

@QuLogicQuLogic merged commitaad2a58 intomatplotlib:mainJul 4, 2024
44 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 4, 2024
@anntzeranntzer deleted the pw branchJuly 4, 2024 00:20
QuLogic added a commit that referenced this pull requestJul 4, 2024
…430-on-v3.9.xBackport PR#28430 on branch v3.9.x (Fix pickling of AxesWidgets.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
topic: pickleIssues to do with picklingtopic: widgets/UI
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

[ENH]: pickle (or save) matplotlib figure with insteractive slider
4 participants
@anntzer@tacaswell@ksunden@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp