Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix circleci yaml#28427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfromksunden:circle_yaml
Jun 20, 2024
Merged

Fix circleci yaml#28427

rcomer merged 1 commit intomatplotlib:mainfromksunden:circle_yaml
Jun 20, 2024

Conversation

ksunden
Copy link
Member

PR summary

Follow up to#28425 and#28413

YAML is sometimes confusing and puts the ending\n on a multiline string with|, which made the job fail.

I moved the comment, hopefully it doesn't mess with dependabot being able to automatically update it, but the line was still too long with the comment on the same line.

PR checklist

@QuLogic
Copy link
Member

Just wondering how this works with dependabot if the version is elsewhere?

@rcomer
Copy link
Member

Wecould just increase the max line length to 119...

@ksunden
Copy link
MemberAuthor

For reference, Dependabot appears to only look at inlined comments following the SHA hash:

https://github.com/dependabot/dependabot-core/blob/b78e6194fb6f8d609a0ded3f0c367962fcd946c6/github_actions/lib/dependabot/github_actions/file_updater.rb#L81

Examples from their tests can be found in:

https://github.com/dependabot/dependabot-core/blob/b78e6194fb6f8d609a0ded3f0c367962fcd946c6/github_actions/spec/fixtures/workflow_files/pinned_sources_version_comments.yml#L7

(Mostly leaving this as a future reference for when this comes up again... who knows if I'll think to find this, but would rather have it if I can)

@rcomerrcomer merged commitc010a36 intomatplotlib:mainJun 20, 2024
38 of 41 checks passed
rcomer added a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 20, 2024
@rcomerrcomer added this to thev3.9.1 milestoneJun 20, 2024
@rcomer
Copy link
Member

Added the backport commit to the existing#28426

rcomer added a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

3 participants
@ksunden@QuLogic@rcomer
[8]ページ先頭
©2009-2025 Movatter.jp