Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix Circle yaml line length#28425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromrcomer:circle-ci-line-length
Jun 19, 2024

Conversation

rcomer
Copy link
Member

PR summary

#28413 introduced a pre-commit failure for the line length, that we missed amongst all the other CI failures.

PR checklist

@rcomerrcomer added the Documentation: buildbuilding the docs labelJun 19, 2024
@rcomerrcomer added this to thev3.9.1 milestoneJun 19, 2024
@ksundenksunden merged commit603001f intomatplotlib:mainJun 19, 2024
35 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 19, 2024
@ksunden
Copy link
Member

ksunden commentedJun 19, 2024•
edited
Loading

Hmmm... this worked here in the PR, but failed with "unable to find version \n" once merged... that is

I note that the newline is included in the error message, which is likely important.

I believe that since it is triggered by[status] the version on main is always the one that is run, which makes changing it challenging since it can't be tested without merging...

@ksundenksunden mentioned this pull requestJun 19, 2024
5 tasks
@rcomerrcomer deleted the circle-ci-line-length branchJune 19, 2024 20:22
ksunden added a commit that referenced this pull requestJun 21, 2024
…425-on-v3.9.xBackport PR#28425 on branch v3.9.x (Fix Circle yaml line length)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: buildbuilding the docs
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

3 participants
@rcomer@ksunden@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp