Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add 'auto' state for boxplot's patch_artist#28420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
saranti wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromsaranti:patchartist

Conversation

saranti
Copy link
Contributor

PR summary

In#17959, it was generally agreed that it should be simpler to set the facecolor on a boxplot. I went with@timhoffm'sidea to change the default topatch_artist='auto' which would use patches if any of the given parameters requires patches.

The 2 boxprops parameters that require a Patch artist arefacecolor andedgecolor. If any of those 2 are passed,patch_artist will auto default to True. Otherwise, the rcparam will be respected.

PR checklist

@anntzer
Copy link
Contributor

I didn't look into this in detail, but would it be possible to just always switch to using a patch artist, using a strategy similar to#24455/#25247 ("auto-switch back to the old kind if the user tries to access the object") during the transition period?

@saranti
Copy link
ContributorAuthor

saranti commentedJun 19, 2024
edited
Loading

I'll look into it

Edit: Always using a patch gives us a problem when someone tries to customize the box usingsetp or tries to call a Line2d method on the box, like in theIID bootstrap example. I don't see a way around that.

@sarantisaranti marked this pull request as draftJune 19, 2024 09:59
@sarantisaranti added the status: needs comment/discussionneeds consensus on next step labelJun 23, 2024
@sarantisaranti requested a review fromanntzerJune 25, 2024 15:11
@anntzer
Copy link
Contributor

Edit: Always using a patch gives us a problem when someone tries to customize the box using setp or tries to call a Line2d method on the box, like in theIID bootstrap example. I don't see a way around that.

The point would be to auto-backconvert (with warning) to the "old" form if that happens, as in#24455/#25247.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzerAwaiting requested review from anntzer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@saranti@anntzer

[8]ページ先頭

©2009-2025 Movatter.jp