Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: stale root Figure when adding/updating subfigures#28397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromrcomer:subfigure-stale
Jun 26, 2024

Conversation

rcomer
Copy link
Member

PR summary

Fixes#28384

PR checklist

@rcomerrcomer added the PR: bugfixPull requests that fix identified bugs labelJun 14, 2024
@rcomerrcomer added this to thev3.9.1 milestoneJun 26, 2024
@tacaswelltacaswell merged commitd347c32 intomatplotlib:mainJun 26, 2024
44 of 45 checks passed
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d347c3227f8de8a99aa327390fee619310452a96
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #28397: FIX: stale root Figure when adding/updating subfigures'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-28397-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR#28397 on branch v3.9.x (FIX: stale root Figure when adding/updating subfigures)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@rcomerrcomer deleted the subfigure-stale branchJune 27, 2024 07:28
rcomer pushed a commit to rcomer/matplotlib that referenced this pull requestJun 27, 2024
Backport PRmatplotlib#28397: FIX: stale root Figure when adding/updating subfigures(cherry picked from commitd347c32)
QuLogic added a commit that referenced this pull requestJun 27, 2024
Backport PR#28397 (FIX: stale root Figure when adding/updating subfigures)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
PR: bugfixPull requests that fix identified bugstopic: figures and subfigures
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

[Bug]: subfigure artists not drawn interactively
3 participants
@rcomer@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp