Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Clean up some Meson-related leftovers#28257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file is created by Meson now, so this isn't needed, and we'vepreviously removed it from the `.gitignore`.
These have all been replaced by Meson build options.
tacaswell approved these changesMay 19, 2024
ksunden approved these changesMay 20, 2024
d6df77c intomatplotlib:main 45 of 47 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 20, 2024
timhoffm added a commit that referenced this pull requestMay 21, 2024
…257-on-v3.9.xBackport PR#28257 on branch v3.9.x (Clean up some Meson-related leftovers)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Meson creates
_version.pyin the build directory, so we shouldn't ask setuptools-scm to do it. I'm not sure why it started creating it again, but taking this option out should stop it.Also, there's some documentation about
mplsetup.cfgthat is out of date, and should be replaced by Meson build options.PR checklist