Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
DOC: we do not need the blit call in on_draw#28231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
on_draw is triggered via the draw_event callback which is processed after therest of the rendering in finished, but before the buffer is painted to thescreen so the `blit` call was at best redundent (causing two copies of thebuffer from our side to the GUI side) and at worst causes segfaults in someversions of Qt.Closesmatplotlib#28002
timhoffm approved these changesMay 16, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 16, 2024
QuLogic added a commit that referenced this pull requestMay 16, 2024
…231-on-v3.9.xBackport PR#28231 on branch v3.9.x (DOC: we do not need the blit call in on_draw)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_draw is triggered via the draw_event callback which is processed after the rest of the rendering in finished, but before the buffer is painted to the screen so the
blitcall was at best redundent (causing two copies of the buffer from our side to the GUI side) and at worst causes segfaults in some versions of Qt.Closes#28002