Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Followup corrections to #28205#28207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromQuLogic:old-ipython
May 13, 2024

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedMay 10, 2024•
edited
Loading

PR summary

Make the changes suggested by@ianthomas23 in#28205, and also mark the ipython tests as using their backend. While the backend is already checked for availability at the top of the respective files, that only checks whether it can be imported, not whether it can be set as the Matplotlib backend. Adding the marker causes our pytest configuration to actually check and skip the test if unavailable (e.g., on Linux without(WAYLAND_)DISPLAY set fails to set an interactive backend).

PR checklist

Make the changes suggested by@ianthomas23, and also mark the ipythontests as using their backend. While the backend is already checked foravailability at the top of the respective files, that only checkswhether it can be imported, not whether it can be set as the Matplotlibbackend. Adding the marker causes our pytest configuration to actuallycheck and skip the test if unavailable (e.g., on Linux without`(WAYLAND_)DISPLAY` set fails to set an interactive backend).
@QuLogic
Copy link
MemberAuthor

I'm milestoning this as 3.10 only so that the backport bot doesn't trigger; I pushed this backport directly to#28206.

@ksundenksunden merged commit955432c intomatplotlib:mainMay 13, 2024
51 checks passed
@ksundenksunden modified the milestones:v3.10.0,v3.9.0May 13, 2024
@ksunden
Copy link
Member

Remilestoned back to 3.9 post merge so no backport bot, but still will be caught by github stats/if we need to look back at it at some point/etc.

@QuLogicQuLogic deleted the old-ipython branchMay 15, 2024 18:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ianthomas23ianthomas23ianthomas23 approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ksunden@ianthomas23
[8]ページ先頭
©2009-2025 Movatter.jp