Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.2k
Support removing absent tools from ToolContainerBase.#28171
Merged
QuLogic merged 1 commit intomatplotlib:mainfromMay 6, 2024
Merged
Support removing absent tools from ToolContainerBase.#28171QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
timhoffm approved these changesMay 4, 2024
ToolManager.remove_tool calls ToolContainerBase.remove_toolitem(via a tool_removed_event) and cannot know (due to the lack of API)whether the tool is actually on the container (it can also be akeybind-only tool not associated with any entry on the toolbar), soToolContainerBase.remove_toolitem should work (as a no-op) even fortools not present on the container.
QuLogic approved these changesMay 6, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 6, 2024
QuLogic added a commit that referenced this pull requestMay 7, 2024
…171-on-v3.9.xBackport PR#28171 on branch v3.9.x (Support removing absent tools from ToolContainerBase.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToolManager.remove_tool calls ToolContainerBase.remove_toolitem (via a tool_removed_event) and cannot know (due to the lack of API) whether the tool is actually on the container (it can also be a keybind-only tool not associated with any entry on the toolbar), so ToolContainerBase.remove_toolitem should work (as a no-op) even for tools not present on the container (and not even set a message in that case, IMO).
Closes#28166 (see example there). Again I'd say this is a symptom of the MEP22 design (toolmanager not knowing whether a tool is actually in the toolcontainer makes things awkward), but let's just go for the minimal fix.
PR summary
PR checklist