Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove call to non-existent method _default_contains in Artist#28157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tacaswell approved these changesMay 1, 2024
QuLogic approved these changesMay 1, 2024
f00b22d
intomatplotlib:main 42 of 43 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 1, 2024
…ault_contains in Artist
ksunden added a commit that referenced this pull requestMay 3, 2024
…157-on-v3.9.xBackport PR#28157 on branch v3.9.x (Remove call to non-existent method _default_contains in Artist)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This is a follow-up from#25546, whihch removed the
_default_contains
method.A similar change was made to several other classes, such as Axes and Figure,
however the call within Artist itself was not removed.
This has evidently not presented a problem to anybody (that we know of), since most
artists (that are used interactively at least) have their own
contains
method.However, if one were to have an Artist without a contains instead of returning
False, {}
,you would get an AttributeError.
Considered adding a test, but opted not to initially. (Willing to be talked into doing so)
PR checklist