Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove call to non-existent method _default_contains in Artist#28157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromksunden:default_contains
May 1, 2024

Conversation

ksunden
Copy link
Member

PR summary

This is a follow-up from#25546, whihch removed the_default_contains method.
A similar change was made to several other classes, such as Axes and Figure,
however the call within Artist itself was not removed.

This has evidently not presented a problem to anybody (that we know of), since most
artists (that are used interactively at least) have their owncontains method.

However, if one were to have an Artist without a contains instead of returningFalse, {},
you would get an AttributeError.

Considered adding a test, but opted not to initially. (Willing to be talked into doing so)

PR checklist

@tacaswelltacaswell added this to thev3.9.0 milestoneMay 1, 2024
@tacaswelltacaswell merged commitf00b22d intomatplotlib:mainMay 1, 2024
42 of 43 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 1, 2024
ksunden added a commit that referenced this pull requestMay 3, 2024
…157-on-v3.9.xBackport PR#28157 on branch v3.9.x (Remove call to non-existent method _default_contains in Artist)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@ksunden@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp