Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Disable clipping in Agg resamplers.#28122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Wow, this looks like a really nice simplification and should fix some of the high dynamic range issues where we ran into problems around the 0.1/0.9 floating point representation creating incorrect under/over values. Is this waiting on#28061 ? |
Apologies for the slow reply, I have basically no time to work on this these days (just a temporary thing). |
TBH, I've not followed the relation with#28061, so I'm not clear whether we can just merge or whether we should wait. The change itself is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is likely correct and certainly doesn't need to wait on#28061. But maybe@tacaswell should weigh in as the previous method was his.
I chose to add macro guards directly in the agg source as that seemedeasier than copy-pasting the whole code.I chose to bump the tolerance on test_rgba_antialias (as that'salso getting bumped by the interpolation_stage antialias PR) and totest_pngsuite (which is not particularly relevant), and to update theother baselines.
24c3f1a intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Thank you for getting this done! |
I chose to add macro guards directly in the agg source as that seemed easier than copy-pasting the whole code.
I chose to bump the tolerance on test_rgba_antialias (as that's also getting bumped by the interpolation_stage antialias PR) and to test_pngsuite (which is not particularly relevant), and to update the other baselines.
PR summary
PR checklist