Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enables setting hatch linewidth in Patches and Collections, also fixes setting hatch linewidth by rcParams#28048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 16 commits intomatplotlib:mainfromImpaler343:linewidth
Oct 31, 2024

Conversation

Impaler343
Copy link
Contributor

@Impaler343Impaler343 commentedApr 9, 2024
edited
Loading

PR summary

Fixes#21108 using the patch provided by@anntzer which I modified to pass tests. Need to write tests for:

  • Setting hatch linewidth in a Patch
  • Setting hatch linewidth in a Collection

PR checklist

@Impaler343
Copy link
ContributorAuthor

Impaler343 commentedApr 10, 2024
edited
Loading

I don't know why docs and CI are failing, could somebody please check this out?

@rcomer
Copy link
Member

Hi@Impaler343, I'm not certain but I think the docs failure may be related to something that has been fixed onmain. Could you try rebasing?

git fetch upstreamgit rebase upstream/main

Appveyor is showing the same failure on all PRs right now, so I wouldn't worry about that one.

Impaler343 reacted with thumbs up emoji

@Impaler343
Copy link
ContributorAuthor

Do I also need to squash?

@tacaswell
Copy link
Member

There is enough exploration/experimentation in here it is probably worth squashing to a handful of commits.

Impaler343 reacted with thumbs up emoji

@tacaswelltacaswell added this to thev3.10.0 milestoneApr 10, 2024
@tacaswell
Copy link
Member

I think this is like 80% of the way there and looking pretty good!

Impaler343 reacted with heart emoji

@Impaler343
Copy link
ContributorAuthor

Impaler343 commentedApr 11, 2024
edited
Loading

Can we get a feature forcheck_figures_equal() similar toimage_comparison()'sremove_text feature? As the former is a more economical way to test, having it forcheck_figures_equal() would be a good idea. Or is it already available, and I don't see it?

@oscargus
Copy link
Member

Can we get a feature forcheck_figures_equal() similar toimage_comparison()'sremove_text feature?

I do not think this is required? The reasonremove_text exists is that the font files may be different on different machine. However,check_figures_equal() are executed on the same machine, so should never be a problem. Am I missing something?

@Impaler343
Copy link
ContributorAuthor

Impaler343 commentedApr 15, 2024
edited
Loading

Can we get a feature forcheck_figures_equal() similar toimage_comparison()'sremove_text feature?

I do not think this is required? The reasonremove_text exists is that the font files may be different on different machine. However,check_figures_equal() are executed on the same machine, so should never be a problem. Am I missing something?

I suggested this as it is a quick plugin to make tests run faster by focussing on the important part of the plot, by removing axes, labels and ticks, and this most probably should make a significant difference while running a large amount of tests

@tacaswelltacaswell merged commitc52cb41 intomatplotlib:mainOct 31, 2024
41 of 43 checks passed
@ksundenksunden mentioned this pull requestOct 31, 2024
5 tasks
ksunden added a commit to ksunden/matplotlib that referenced this pull requestOct 31, 2024
Problems were introduced bymatplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
ksunden added a commit to ksunden/matplotlib that referenced this pull requestOct 31, 2024
Problems were introduced bymatplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
ksunden added a commit to ksunden/matplotlib that referenced this pull requestNov 1, 2024
Problems were introduced bymatplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
@jkseppanjkseppan mentioned this pull requestMay 18, 2025
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden left review comments

@oscargusoscargusoscargus left review comments

Assignees
No one assigned
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Hatch linewidths cannot be modified in an rcParam context
6 participants
@Impaler343@rcomer@tacaswell@oscargus@QuLogic@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp