Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Clarify merge policy#28046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 2 commits intomatplotlib:mainfromtimhoffm:doc-clarify-merge-policy
May 9, 2024

Conversation

timhoffm
Copy link
Member

Inspired by questions on some edge cases in the past (e.g.#28043 (review)).

One of the approvers should be@tacaswell .

rcomer reacted with heart emoji
@timhoffmtimhoffm requested a review fromtacaswellApril 8, 2024 12:06
@github-actionsgithub-actionsbot added the Documentation: devdocsfiles in doc/devel labelApr 8, 2024
@timhoffmtimhoffmforce-pushed thedoc-clarify-merge-policy branch from5266d93 to1aa9722CompareApril 8, 2024 12:08
@timhoffmtimhoffm added this to thev3.10.0 milestoneApr 8, 2024
@timhoffmtimhoffmforce-pushed thedoc-clarify-merge-policy branch 2 times, most recently fromfc19cfc to10cc1b5CompareApril 8, 2024 12:22
Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

mostly copy editing nits, I'm staying out of the review process for this.

@timhoffmtimhoffmforce-pushed thedoc-clarify-merge-policy branch from10cc1b5 to07906ddCompareApril 8, 2024 20:17
@timhoffm
Copy link
MemberAuthor

ping

@tacaswell
Copy link
Member

It is docs, but I would like a second review on this.

@rcomer
Copy link
Member

I think this needs a rebase to pick up#28094.

timhoffm reacted with thumbs up emoji

timhoffmand others added2 commitsMay 6, 2024 21:38
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
@timhoffmtimhoffmforce-pushed thedoc-clarify-merge-policy branch from9bc06ca to11de885CompareMay 6, 2024 19:39
@rcomer
Copy link
Member

Possibly tangential to this PR but

to do so, they should ping all core devs both on GitHub and on the dev
mailing list, and label the PR with the "Merge with single review?" label.

I am not on any dev mailing list. Should I be?

@story645
Copy link
Member

story645 commentedMay 8, 2024•
edited
Loading

I am not on any dev mailing list. Should I be?

Couldn't hurt, it'shttps://mail.python.org/mailman/listinfo/matplotlib-devel

which follow up would maybe be cross linking to the mailing list list:ref:`mailing-lists`

Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change is clear and very welcome.

@rcomer
Copy link
Member

Apologies for the tangent. Because of the context my brain went “wait, is there a mailing list for core devs?”

story645 reacted with thumbs up emoji

@rcomerrcomer merged commitd67f08e intomatplotlib:mainMay 9, 2024
@timhoffmtimhoffm deleted the doc-clarify-merge-policy branchMay 9, 2024 12:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 left review comments

@tacaswelltacaswelltacaswell approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Labels
Documentation: devdocsfiles in doc/devel
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

4 participants
@timhoffm@tacaswell@rcomer@story645
[8]ページ先頭
©2009-2025 Movatter.jp