Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Respect vertical_axis when rotating plot interactively#28039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 5 commits intomatplotlib:mainfromIllviljan:vertical_axis_on_move
May 1, 2024

Conversation

Illviljan
Copy link
Contributor

@IllviljanIllviljan commentedApr 7, 2024•
edited
Loading

PR summary

In#25821view_init was added inax._on_move without all the arguments. This meant that the initial plot looked as intended withvertical_axis="x", but once the plot was rotated interactively thevertical_axis was reset back to the default position.

PR checklist

@IllviljanIllviljan marked this pull request as ready for reviewApril 7, 2024 15:06
Copy link
Contributor

@scottshambaughscottshambaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, thanks for catching this! Not sure if a bugfix warrants a what's new, but not a big deal either way.

@oscargusoscargus added this to the3.9.1 milestoneApr 15, 2024
@oscargus
Copy link
Member

oscargus commentedApr 15, 2024•
edited
Loading

Bug fixes usually do not get a "What's new", so if you remove that I'd be happy to merge this. Thanks!

(Edit: as this was introduced in 3.8, I suggest to backport to 3.9.10. Hence the marking.)

@oscargusoscargus modified the milestones:3.9.1,v3.9.0Apr 15, 2024
@scottshambaugh
Copy link
Contributor

You'll have to rebase squash your commits to pass the PR cleanliness check, but I think the other CI failures are unrelated.

@Illviljan
Copy link
ContributorAuthor

I don't know how to do that.
Why isn't Squash and merge good enough?

@scottshambaugh
Copy link
Contributor

That works as well! We need a second maintainer to approve the PR before it can be merged, but I or them can squash merge it.

Illviljan reacted with thumbs up emoji

@QuLogicQuLogic merged commit63156f2 intomatplotlib:mainMay 1, 2024
11 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 1, 2024
QuLogic added a commit that referenced this pull requestMay 4, 2024
…039-on-v3.9.xBackport PR#28039 on branch v3.9.x (Respect vertical_axis when rotating plot interactively)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@scottshambaughscottshambaughscottshambaugh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

[Bug]: vertical_axis not respected when rotating plots interactively
4 participants
@Illviljan@oscargus@scottshambaugh@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp