NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Inform tool-manager that wx backend wants icons in svg format#28008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

jmoraleda wants to merge1 commit intomatplotlib:mainfromjmoraleda:fix-26710

Closed

Inform tool-manager that wx backend wants icons in svg format#28008

jmoraleda wants to merge1 commit intomatplotlib:mainfromjmoraleda:fix-26710

Conversation

Copy link

Contributor

jmoraleda commentedApr 2, 2024

The refactoring in PR#26710 modified the wx backend to use resolution-independent tool icons insvg format. But informing tool-manager of this change was not done. So toolbar icons do not work when using tool-manager in conjunction with the wx backend. This in particular triggered issue#28007

This PR addresses this problem by informing tool-manager that the wx backend wants icons in svg format.

Inform tool-manager that wx backend wants icons in svg format

b3c9799

github-actionsbot added the GUI: wx label

Apr 2, 2024

Copy link

Member

ksunden commentedApr 2, 2024

See also#28007, which does essentially the same thing (though in the class definition, rather than in__init__. That seemed to still have the problem on appveyor though, so if this somehow fixes it where that one did not, I guess we can go with this one.

There is a Linting error, though only an extra space required for the inline comment.