Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Unpin numpy 2, build against prerelease numpy in CIBW#27993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:v3.8.xfromksunden:np_2_build
Apr 3, 2024

Conversation

ksunden
Copy link
Member

PR summary

This is in preparation for an mpl prerelease of 3.8.4rc1 (built against numpy beta, hence rc)

We may wish to do the same change to the CIBW job onmain (@QuLogic thoughts?) as that will also affect the builds uploaded to nightly.

I did it just for the release branch for now, in part because I needed to unpin in setup.py anyway.

PR checklist

@ksundenksunden marked this pull request as draftMarch 29, 2024 17:49
@ksundenksunden added the CI: Run cibuildwheelRun wheel building tests on a PR labelMar 29, 2024
@ksunden
Copy link
MemberAuthor

Converted to draft only because I do wish to test the wheels on this branch against numpy (2.0b1, 1.26 (most recent stable), and 1.21 (oldest supported by this branch))

There are also some interactions with contourpy, but not in a way that I think it makes sense for us to enforce: if you are using np 2, you need the most recent version of contourpy as well. We do not have a build time dependency on contourpy, so it does not affect wheel building.

I did not pin the version of pybind11 that we need, as that only matters for those building to use with numpy 2. (It is now the most recent stable version)

@ksundenksundenforce-pushed thenp_2_build branch 4 times, most recently from0d87a7c toece8f9aCompareMarch 30, 2024 00:07
@ksundenksunden marked this pull request as ready for reviewMarch 30, 2024 06:21
@ksunden
Copy link
MemberAuthor

Everything checked out locally for me (alittle hard to test release wheels without images, but managed to get the majority of tests to run and the subset which fail also fail with released mpl 3.8.3 and np 1.26)

Notably, the tests which were known to be problematic with np 2.0b1 and pybind11 2.11 passed on all three test setups (essentially current releases, min version, and prerelease)

@QuLogicQuLogic added this to thev3.8.4 milestoneApr 2, 2024
@QuLogic
Copy link
Member

We may wish to do the same change to the CIBW job onmain (@QuLogic thoughts?) as that will also affect the builds uploaded to nightly.

We can do that as part of the merge up if it's done before branching, I think.

@tacaswelltacaswell merged commite0a38c6 intomatplotlib:v3.8.xApr 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PR
Projects
None yet
Milestone
v3.8.4
Development

Successfully merging this pull request may close these issues.

3 participants
@ksunden@QuLogic@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp