Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
gtk4: Implement auto-colouring of toolbar icons#27989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
QuLogic wants to merge3 commits intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Originally, the resize event happens first, adds an idle draw callback,and then the widget draws itself. Since the draw callback only happenswhen _idle_, it happens after the draw, so the figure appears blank.After the mouse is released, the idle draw callback fires, and thefigure appears again.This is already done in the Qt backend [1], and doing so ensures thefigure remains visible during resizes with the mouse.[1]https://github.com/matplotlib/matplotlib/blob/0afc5d6ca49cf6e8aa1da76b5bab0faca2f340f2/lib/matplotlib/backends/backend_qtagg.py#L25
In GTK4, colouring of symbolic icons only takes place for icons thatcome from an icon theme. The easiest way to replicate that is to add ourown theme to the search path, but this means following the specialdirectory layout [1], so move the -symbolic symlinks to enable that.We don't really need to change GTK3 as well, but doing so removes theneed for an extra set of symlinks.https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In GTK4, colouring of symbolic icons only takes place for icons that come from an icon theme. The easiest way to replicate that is to add our own theme to the search path, but this means following the special directory layout [1], so move the
-symbolicsymlinks to enable that.We don't really need to change GTK3 as well, but doing so removes the need for an extra set of symlinks.
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout
To test, you can run with
GTK_DEBUG=interactive, and in the inspector window that pops up, toggle the "Dark variant" in the Settings.PR checklist