Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

qhull: Fix inconsistent formatting function arguments#27987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
QuLogic wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromQuLogic:qhull-printf-fixes

Conversation

QuLogic
Copy link
Member

PR summary

This is a backport ofqhull/qhull#143, and should fix all of the related CodeQL alerts.

PR checklist

@QuLogic
Copy link
MemberAuthor

Hmm, I don't know where to find the results for CodeQL when a PRfixes alerts (unless it didn't fix them of course.)

@QuLogicQuLogic marked this pull request as draftMarch 28, 2024 23:57
@QuLogic
Copy link
MemberAuthor

I pushed this tomain on my fork, and it did drop CodeQL alerts by 13. Unfortunately, the patch was broken for Windows wheels due to Strawberry Perl's brokenpatch command. I think there's something in Meson upstream to fix that, but I'm not sure the state of it.

This is a backport ofqhull/qhull#143, andshould fix all of the related CodeQL alerts.
@QuLogicQuLogic marked this pull request as ready for reviewJuly 5, 2024 08:47
@QuLogicQuLogic added Build CI: Run cibuildwheelRun wheel building tests on a PR labelsJul 5, 2024
@QuLogic
Copy link
MemberAuthor

It looks like the latest Meson picks a suitablepatch implementation on Windows, so this is good now.

@QuLogic
Copy link
MemberAuthor

But then wheel building shows up 3 times, but is actually failing.

@QuLogicQuLogic marked this pull request as draftJuly 5, 2024 09:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BuildCI: Run cibuildwheelRun wheel building tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@QuLogic@cbbarber
[8]ページ先頭
©2009-2025 Movatter.jp