Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TST: Remove superfluous chdir from tests#27985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
These tests don't chdir back to the original directory on exit, soanything using the current directory would be in the temporary directoryof this test.Most notably, any image comparison results would be dumped in thattemporary directory instead of the usual `result_images` in the currentdirectory.
ksunden approved these changesMar 28, 2024
timhoffm approved these changesMar 28, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
These tests don't chdir back to the original directory on exit, so anything using the current directory would be in the temporary directory of this test.
Most notably, any image comparison results would be dumped in that temporary directory instead of the usual
result_imagesin the current directory.I noticed this while debugging#27723, as the failing test images were not in the artifacts, and logs showed them saved in a temporary directory:https://github.com/matplotlib/matplotlib/actions/runs/8458560380/job/23173084420#step:13:183
PR checklist