Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BUG: Fix NonUniformImage with nonlinear scale#27964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi, would appreciate having someone look over this PR whenever you have the chance. Thanks! |
lib/matplotlib/tests/test_image.py Outdated
| ax.set_yscale("log") | ||
| if i == 2: | ||
| ax.set_xscale("log", base=2) | ||
| ax.set_yscale("log", base=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Right now it seems like the two bottom figures are identical?
Can you change so that the x-scale has base 3 instead? In that way it may be easier to see that it actually makes a difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn't change the logic for picking pixel centers in this PR, so changing the base doesnt alter the image visually
98506d0 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Fixes a bug with NonUniformImage, where the image distorts when panning with a
nonlinear scale. Also addresses#13442, so the image correctly renders when the axes
scale changes.
Closes#27820.
PR checklist