Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update "Created with" url in hand.svg#27933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromavolkov-astra:update-sodipodi-url
Mar 15, 2024

Conversation

avolkov-astra
Copy link
Contributor

Current url points to online sextoys store.

Current url points to online sextoys store.
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswell
Copy link
Member

Indeed it does.

@tacaswelltacaswell added this to thev3.8.4 milestoneMar 15, 2024
@ksunden
Copy link
Member

A far as I can tell, this file is entirely unused (at least internally), is there any reason not to just remove it (and the png/pdf versions) entirely?

I guess technically it is available to downstream toolbars...

(It is also the only image in mpl-data that isnot created with mpl itself, so another thought I had was to recreate in mpl)

All that said, this is updating a comment that is pointing to a clearly wrong place (now, I suspect it was accurate at the time, this file was last edited 18 years ago, at least in contents). So I have no qualms with this change in the immediate term, just thought an even more complete solution may be possible.

@ksunden
Copy link
Member

Merging over appveyor failure (which was in conda env creation, not even our own failure) as this is only editing a comment in an svg anyway.

@ksundenksunden merged commit69a1a75 intomatplotlib:mainMar 15, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 15, 2024
ksunden added a commit that referenced this pull requestMar 15, 2024
…933-on-v3.8.xBackport PR#27933 on branch v3.8.x (Update "Created with" url in hand.svg)
@ksundenksunden mentioned this pull requestApr 4, 2024
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.8.4
Development

Successfully merging this pull request may close these issues.

3 participants
@avolkov-astra@tacaswell@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp