Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[BUG] Fix redirect-from Sphinx extension#27915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

trananso
Copy link
Contributor

PR summary

Closes#27911,closes#21876. This PR fixes the issue of redirect-from directives not
creating the relative refresh pages in the build.

PR checklist

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Theclear_doc change to operating on a single document is correct. Clearing everything was a mistake.

Why do we have to delete the consistency checks?

@trananso
Copy link
ContributorAuthor

If the docs build successfully the first time with no changes, Sphinx will load in a cached build environment withdomain.requests already populated. Hence, that check will cause the build to fail

@tacaswell
Copy link
Member

Sphinx will load in a cached build environment with domain.requests already populated. Hence, that check will cause the build to fail

But that suggests the checks are doing their job and we still have a bug?

@trananso
Copy link
ContributorAuthor

Added the sanity checks back in. Also added a function to clear the domain redirects, so build doesnt fail when rebuilding without doing amake clean.

@tranansotrananso changed the titleFix redirect-from Sphinx extension[BUG] Fix redirect-from Sphinx extensionMar 14, 2024
@tranansotrananso requested a review fromtimhoffmMarch 15, 2024 13:57
@tranansotrananso requested a review fromtimhoffmMarch 18, 2024 16:40
Implement suggested changesCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogicQuLogic merged commitbb3f0dc intomatplotlib:mainMar 20, 2024
@QuLogicQuLogic added this to thev3.9.0 milestoneMar 20, 2024
@tranansotrananso deleted the fix-sphinx-redirect-from-directives branchMarch 20, 2024 13:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

redirect not working for updated contribute page [Doc]: redirect-from directive appears broken?
4 participants
@trananso@tacaswell@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp