Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deleting all images that have passed tests before upload#27881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It is flaky, and our memory "limit" is pretty much arbitrary. Testingwith `tools/memleak.py` shows that memory usage generally rises and onlystabilizes close to 200 figures, while this test only does a warmup of2 figures. Waiting for equilibrium would take too long for a generaltest, so we might move this to a weekly job later.
- Turn each norm into a headed section.- Link to each norm directly in text.- Consistently use `Z` as data variable, and pass norms (or `vmin`) in the same order for every example.- Label the colour bars.- Tweak some descriptions to be clearer.- Change data for SymLogNorm and use it for the custom norm and BoundaryNorm, in order to match their descriptions.
- deprecated cm api removal documentation- Corrected formatting issues with documentation- Removed corresponding type sub in related cm.pyi file and exceptions in mypy-stubtest- Removed tests, updated documentation with code style for removed functions, moved code to pyplot from cm- Revert "Removed tests, updated documentation with code style for removed functions, moved code to pyplot from cm" This reverts commita8a4f7f.- Documetation updates to match code style for deprecated api's- Removed tests for deprecated api's- Corrected documentation with full path and verbiage on removals- Removed handling of override builtin from ColorMaRegistry
EffVer very closely articulates what we are already doing.Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
This new name was added in Meson 1.1, which is our minimum requirement.
This was added in 0.62, and maybe is a bit more portable.
This doesn't get used for anything effectively, but perhaps meson-pythonwill start using it eventually.
Inspired from the discussion inmatplotlib#27765: We should visually communicatethat `plot()` covers all three variants: markers only,line+markers, line-only.They are visually distinct enough that it's not possibleto infer the variants if you see only one.In particular, it's important to communicate that youcan draw markers only. We don't want to automatically drive people whowant markers (e.g. some discrete measurements of a dependent variable y(x)) to scatter because that's the only one showing discrete markers in the overview.
Bumps the actions group with 2 updates: [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) and [codecov/codecov-action](https://github.com/codecov/codecov-action).Updates `pypa/cibuildwheel` from 2.16.4 to 2.16.5- [Release notes](https://github.com/pypa/cibuildwheel/releases)- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)- [Commits](pypa/cibuildwheel@0b04ab1...ce3fb78)Updates `codecov/codecov-action` from 3 to 4- [Release notes](https://github.com/codecov/codecov-action/releases)- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)- [Commits](codecov/codecov-action@v3...v4)---updated-dependencies:- dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions- dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions...Signed-off-by: dependabot[bot] <support@github.com>
Simplify example: Box plots with custom fill colorsThe [original example](https://matplotlib.org/3.8.0/gallery/statistics/boxplot_color.html) was more complex than need be:- The two plots only differed in the `notch=True` parameter, which is irrelevant for custom fill colors -> reduce to one- rework to a more realistic-like plot---------Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
If you are using this and really need unbounded timeouts, explicitlypass `timeout=None`
On windows on py312 we can not use `.communicate` during process shutdownbecause it internally uses Python threads which can no longer be created duringinterpreter shutdown.Closesmatplotlib#27437
…ind11.h includespybind11 seems decent about including Python.h before any system headers, once you chase three layers of includes in to see that.
2 tasks
Member
timhoffm commentedMar 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Superseded by#27882. Please note that it’s better to force-push to a Pull request branch to clean it up, instead of closing it and opening another PR with the same topic. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backend: aggbackend: pdfbackend: pgfCI: Run cibuildwheelRun wheel building tests on a PR CI: Run cygwinRun cygwin tests on a PR Documentation: buildbuilding the docs Documentation: devdocsfiles in doc/devel Documentation: examplesfiles in galleries/examples Documentation: plot typesfiles in galleries/plot_types GUI: MacOSXGUI: tkstatus: supersededtopic: axestopic: canvas and figure managertopic: collections and mappablestopic: color/color & colormapstopic: geometry managerLayoutEngine, Constrained layout, Tight layout topic: imagestopic: mplot3dtopic: path handlingtopic: pyplot APItopic: text/fontstopic: ticks axis labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Attempts toclose#23400 and potentially complete what PR#19466 intended to do
Included a bash script right before the uploading part of the code in thetests.yml file to delete all image files(.png extension only) that have not failed in the result_images directory. Have tested this using a dummy bash file andtest_images directory, but I do not know the exact structure of this directory when it gets created. The interpretation of the structure comes from reading thetools/visualize_tests.py file. Please let me know if this approach seems correct, or is blatantly wrong :).
A majority of the tests failed for some unrelated reason(Probably due to the new pytest version release)
PR checklist