Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add ten-color accessible color cycle as style sheet#27851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
I am very much in favor of taking this, but agree the name needs some workshopping. We may also want to add these sequence(s) to matplotlib/lib/matplotlib/colors.py Lines 119 to 132 incb8c484
|
If it is ready in the next week or so, it can go in 3.9, but I think it is important to get the names and such rather rather than rushing it through. |
kpedro88 commentedMar 4, 2024
@mpetroff great to see this! As a user, I am in favor of adding the 6- and 8-color cycles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Given the discussion inmpetroff/accessible-color-cycles#1 this PR would adopt thepetroffX
name scheme.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
2db5b79
toc886314
CompareI took the liberty of accepting the naming change, adding it to the sequence registry, and fixing the rebase. |
@mpetroff can we get an approval from you that you're good with the name changes discussed inmpetroff/accessible-color-cycles#1 that were adopted here? |
Yes, I'm good with it. |
@tacaswell@mpetroff Can we rebase this off |
Color cycle survey palette from Petroff (2021):https://arxiv.org/abs/2107.02270https://github.com/mpetroff/accessible-color-cycles
See discussion inmpetroff/accessible-color-cycles#1Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
c886314
toff584d7
Compare
story645 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This can be done in a followup, but would be nice if this got added to the following for discoverability:
https://matplotlib.org/devdocs/users/explain/colors/colormaps.html
https://matplotlib.org/devdocs/gallery/style_sheets/index.html
ETA: also I'm really psyched this is going in, thanks for your work on this folks!
1056e0f
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
I went ahead and merged this and opened issue for the additional examples / documentation. |
Thank you@mpetroff ! |
Probably the wrong place to ask this, but so we can now do importmatplotlib.pyplotaspltplt.style.use("petroff10")petroff10 which is great. 🚀 (Also nice For some high energy physics training sessions the 6 color scheme is sometimes demoed (c.f. the |
The 6 color sequence by Petroff is not just a truncated 10 color sequence. It has distinct colors. You can read thrombus here and make a custom color sequencehttps://arxiv.org/abs/2107.02270. |
PR summary
(Following up from email.)
Adds a style sheet with the ten-color color cycle survey palette from Petroff (2021) [which will be published in a journal eventually]:
https://arxiv.org/abs/2107.02270
https://github.com/mpetroff/accessible-color-cycles
Related to (but does not fix)#9460.
At the moment, this PR contains only the minimal changes. I've only added the ten-color sequence from the paper and only done so as a style sheet.
The paper additionally contains six- and eight-color sequences, which could also be added.
Would it be better to add to
_BUILTIN_COLOR_SEQUENCES
inlib/matplotlib/colors.py
with data inlib/matplotlib/_cm.py
instead of as a style sheet?I'm also open to naming suggestions. The current name is the placeholder I've been using, with
ccs
standing for "color cycle survey".PR checklist