Issue#27630 highlighted how passing asize value insidefontdict was being ignored withinfigure.suptitle. This was happening because the default kwargs sent to Text were being updated with the defaults last (i.e. highest priority). Switching the order of the dictionary update fixes this, giving highest priority to arguments specified infontdict by the user.

Test code by@boffi:

import matplotlib.pyplot as pltfig = plt.figure(figsize=(8, 3), layout='constrained')f0, f1 = fig.subfigures(1, 2)f0.suptitle('xxxXXX', fontdict=dict(family='Candara', size=30))f0.add_subplot().set_title('xxxXXX', fontdict=dict(family='Candara', size=20))f1.suptitle('xxxXXX', size=30, fontdict=dict(family='Candara'))f1.add_subplot().set_title('xxxXXX', size=20, fontdict=dict(family='Candara'))plt.show()

Broken behavior:

Fixed behavior:

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
N/APlotting related features are demonstrated in anexample
N/ANew Features andAPI Changes are noted with adirective and release note
N/A Documentation complies withgeneral anddocstring guidelines

Note: This is my first PR. Please let me know if I messed up anything here.

Suptitle swapping order of updates between defaults and fontdict

d7616cd

This should fix issuematplotlib#27630

github-actionsbot added the topic: figures and subfigures label

Jan 26, 2024

github-actionsbot reviewed

Jan 26, 2024

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

jklymak reviewed

Jan 26, 2024

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add a test to our test suite to make sure this works and continues to work? Probably inlib/matplotlib/tests//test_figure.py.

rcomer added the status: needs tests label

Jan 27, 2024

lcapalleja force-pushed thesuptitle_fontdict_size_bug branch from395d719 to4a78e56Compare

January 29, 2024 18:22

Copy link

Author

lcapalleja commentedFeb 1, 2024

@jklymak, I added a test. Let me know if this needs anything else.

Copy link

Member

jklymak commentedFeb 1, 2024

Is it possible to test without an image test by querying the fontsize? We try to minimize image tests, particularly with text, but sometimes it is unavoidable.

added test for suptitle size specified in fontdict

cd17206

lcapalleja force-pushed thesuptitle_fontdict_size_bug branch from4a78e56 tocd17206Compare

February 6, 2024 18:17

Copy link

Author

lcapalleja commentedFeb 7, 2024

Is it possible to test without an image test by querying the fontsize? We try to minimize image tests, particularly with text, but sometimes it is unavoidable.

@jklymak, made this change. Thank you for the guidance!