Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: fix labeller#27694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromstory645:labeler
Jan 25, 2024
Merged

MNT: fix labeller#27694

QuLogic merged 1 commit intomatplotlib:mainfromstory645:labeler
Jan 25, 2024

Conversation

story645
Copy link
Member

@story645story645 commentedJan 24, 2024
edited
Loading

PR summary

According to the error message and thelabeler docs, I think this was a typo.

eta: also I think running intoactions/labeler#628 and not sure if the fix is it needs to be fixed here and that'll fix it or combined w/ a checkout option.

@story645story645 marked this pull request as draftJanuary 24, 2024 20:02
@story645story645 marked this pull request as ready for reviewJanuary 24, 2024 20:06
@ksunden
Copy link
Member

Comment regarding typo, for reference:

#27689 (comment)

However, I'd like to hear from@QuLogic as to whether the lack of checkout is intentional or not.

story645 reacted with thumbs up emoji

@story645
Copy link
MemberAuthor

#27689 (comment)

🤦‍♀️ knew I saw that somewhere

@story645
Copy link
MemberAuthor

@QuLogic
Copy link
Member

I think you were looking at old docs (and the referenced issue is older than v5); the v5 ones don't mention needing a checkout. In fact, the docs say it will read from the source repo (which it has been doing all this time). And I don't think it would have any effect, aspull_request_target will clone from the main repo, not the fork. That does unfortunately lead to the "can't test beforehand" issue.

So the changes to the workflow appear superfluous, as they are just setting configuration to the defaults and adding a checkout that doesn't do anything.

@story645
Copy link
MemberAuthor

. In fact, the docs say it will read from the source repo (which it has been doing all this time).

I was just confused why it was still getting that error message, but just undid those changes.

@QuLogicQuLogic added this to thev3.9.0 milestoneJan 25, 2024
@QuLogicQuLogic merged commitff0497c intomatplotlib:mainJan 25, 2024
@story645story645 deleted the labeler branchJanuary 25, 2024 05:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@story645@ksunden@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp