Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Axes.inset_axes - warning message removed#27665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 15 commits intomatplotlib:mainfromShivamPathak99:main
Jan 23, 2024

Conversation

ShivamPathak99
Copy link
Contributor

@ShivamPathak99ShivamPathak99 commentedJan 18, 2024
edited by dstansby
Loading

Changed Axes.inset_axes status to stable#27648

Changed the status of Axes.inset_axes from experimental to stable in docs.
Created new file in next_whats_new for inset_axes.
Fixed the wrong fork

Closes#27648

PR checklist

Removed warning message of inset_axesThis method is experimental as of 3.0, and the API may change.
Changed status from experimental to stable
@github-actionsgithub-actionsbot added the Documentation: user guidefiles in galleries/users_explain or doc/users labelJan 18, 2024
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

ksunden
ksunden previously requested changesJan 18, 2024
Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly just doc formatting, but also one unrelated change is included

@ShivamPathak99
Copy link
ContributorAuthor

Why 2 of the checks failed ?

@ksunden
Copy link
Member

One is an unrelated memory problem we have been having (nothing for you to do on that)

The other is wanting the new line at the end of the release note to be taken out, I believe.

@ShivamPathak99
Copy link
ContributorAuthor

codecov/project/tests is failing, but why ?

@tacaswelltacaswell added this to thev3.9.0 milestoneJan 22, 2024
@tacaswelltacaswell changed the titleAxes.inset_axes - warning message remvoved [DOCS]Axes.inset_axes - warning message remvovedJan 22, 2024
@tacaswelltacaswell added API: changes and removed Documentation: user guidefiles in galleries/users_explain or doc/users labelsJan 22, 2024
@tacaswell
Copy link
Member

I'm unclear why the bot added "documention user guide" as this is moving part of the API from experimental to stable so it is closest to an API change.


Coverage data is based on HEAD95b7f68
(10 uploads)
compared to BASE879bde7
(14 uploads)

more CI jobs contributed to the run on the base commit.

From looking at the indirect changes it looks like we are missing an upload from an osx runner and something with a pre-release of pytest8.

@ksunden
Copy link
Member

I'm unclear why the bot added "documention user guide"

The release note matches this file glob:

"Documentation: user guide":
-changed-files:
-any-glob-to-any-file:
-'doc/users/**'

Perhaps that glob can be narrowed (especially fornext_whats_new)

@dstansbydstansby merged commit2122f65 intomatplotlib:mainJan 23, 2024
@QuLogicQuLogic changed the titleAxes.inset_axes - warning message remvovedAxes.inset_axes - warning message removedApr 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

@ksundenksundenksunden left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

[Doc]:Axes.inset_axes is still experimental
6 participants
@ShivamPathak99@ksunden@tacaswell@jklymak@timhoffm@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp