Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: Added call out to API guidelines to contribute + small API guidelines reorg#27650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromstory645:api-guidelines
Jan 17, 2024

Conversation

story645
Copy link
Member

@story645story645 commentedJan 15, 2024•
edited
Loading

PR summary

Spun docs changes out of#27641 to let that one go through faster. Changes here are:

image

  • and since the white space balance feels weird to me, commit 2:
    image

PR checklist

@github-actionsgithub-actionsbot added the Documentation: devdocsfiles in doc/devel labelJan 15, 2024
@story645story645 added this to thev3.9.0 milestoneJan 15, 2024
.. _api_whats_new:

Announce changes, deprecations, and new features
------------------------------------------------
Announce new features, API changes, and deprecations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Take or leave: Announcing is done after one has done the implementation. Therefore I'm slightly in favor of moving this section to the bottom so that the new order is:

  • Add new API and features
  • Deprecate API
  • Announce new features, API changes, and deprecations

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agree, I think what I've done here is blend overview with the announcement specific relevant stuff, so I may separate that out.

@story645story645 marked this pull request as draftJanuary 16, 2024 22:16
added callout in coding guidelines to make more obvious.Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@story645story645 marked this pull request as ready for reviewJanuary 16, 2024 22:53
@story645
Copy link
MemberAuthor

@timhoffm updated it so that the announce section is a bit less overview and pushed it to the bottom.

@timhoffmtimhoffm merged commit690aaf3 intomatplotlib:mainJan 17, 2024
@story645story645 deleted the api-guidelines branchJanuary 17, 2024 15:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: devdocsfiles in doc/devel
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

2 participants
@story645@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp