Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: fix api changes link in PR template#27641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromstory645:pr-template
Jan 15, 2024

Conversation

story645
Copy link
Member

PR summary

As@QuLogic pointed out in#27310 (comment), the pr template now links to the wrong section so changed that. Also tried making the "go to API changes doc" clearer , but don't love the use of admonitions here.

PR checklist

@story645story645 mentioned this pull requestJan 11, 2024
5 tasks
@QuLogic
Copy link
Member

I believe this should have been labelled withDocumentation: devdocs but wasn't due to#27642.

story645 reacted with thumbs up emoji

@story645
Copy link
MemberAuthor

Yeah I didn't label this just to see if the action worked!

@QuLogic
Copy link
Member

Tried to re-run it, but it's still complaining about the same stuff, so I guess it's pulling from the base commit, and not top ofmain. Maybe if you rebase this one it'll figure itself out?

@story645
Copy link
MemberAuthor

so I guess it's pulling from the base commit

is that how it ended up w/ the toolkit label?

@QuLogic
Copy link
Member

Looks like that one is another minor issue in the config:#27644

story645 reacted with thumbs up emoji

@QuLogicQuLogic added this to thev3.9.0 milestoneJan 13, 2024
@story645
Copy link
MemberAuthor

@dstansby@QuLogic do either of you have a preference for admonition vs card for the API changes call out?

@timhoffm
Copy link
Member

@dstansby@QuLogic do either of you have a preference for admonition vs card for the API changes call out?

To me, card feels a bit out of place. Either we regard "API changes" a proper part of the coding guidelines, in which case we should keep the original heading (optionally move that section further down). Or we regard it as a cross-ref hint (think: "if you contribute code, please consider our API changes policy as well"), in which case, I'd go with.. note::.

@story645
Copy link
MemberAuthor

To me, card feels a bit out of place. Either we regard "API changes" a proper part of the coding guidelines, in which case we should keep the original heading (optionally move that section further down). Or we regard it as a cross-ref hint (think: "if you contribute code, please consider our API changes policy as well"), in which case, I'd go with .. note::.

So this change was motivated by the link out to the API guidelines getting kinda buried:

image

I tried a card and I did not like it. Trying a highlight approach now, will post back.

@github-actionsgithub-actionsbot removed the Documentation: devdocsfiles in doc/devel labelJan 14, 2024
@story645story645 changed the titleDOC: fix api changes link in PR template and make API changes linkout more prominant in coding guideDOC: fix api changes link in PR templateJan 14, 2024
@story645
Copy link
MemberAuthor

Changed this PR to just change the link on the PR template so it can go in quickly, moving the docs changes to a different PR

@story645story645 changed the titleDOC: fix api changes link in PR templateMNT: fix api changes link in PR templateJan 14, 2024
@timhoffmtimhoffm merged commit59f6e2b intomatplotlib:mainJan 15, 2024
@story645story645 deleted the pr-template branchJanuary 15, 2024 01:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

4 participants
@story645@QuLogic@timhoffm@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp