Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
DOC: update doc/readme.txt & remove devel/readme#27631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b81a52d tod70558cComparebec4f73 tod501b1cCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
doc/README.txt Outdated
| Content Folders | ||
| ^^^^^^^^^^^^^^^ | ||
| * api - placeholders to automatically generate the api documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe
| * api -placeholders to automatically generate the api documentation | |
| * api -source files to automatically generate the api documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think they're templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me, though they are not templates in the same sense as_templates.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
doc/README.txt Outdated
| During the documentation build, sphinx-gallery creates symlinks from the source folders | ||
| in `/galleries` to target_folders in '/doc'; therefore ensure that you are editing the | ||
| real files rather than the symbolic links: | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I find the table format quite noisy. Would you consider a simple table or a bullet list? If you rather keep the fully outlined table, please separate header and content using = signs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
so my concern w/ a bullet list is tripping up source and target
deleted doc/devel/readme.txt because gitwash is no longer usedCo-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
PR summary
The doc/readme.txt got kinda out of sync w/ the current state of the docs, so I updated it to describe what I think is current state. Waiting on#27560 to spare a rebase there.
Also deleted doc/devel/readme since gitwash was removed in#23588
PR checklist