Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix marker validator with cycler (allow mix of classes)#27613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

faisal-fawad
Copy link
Contributor

@faisal-fawadfaisal-fawad commentedJan 8, 2024•
edited
Loading

PR summary

Closes#27596. Added basic support for combination of strings and integers to satisfy expected behavior.

PR checklist

Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

awesome, can you please add a test?

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@ksunden
Copy link
Member

Please add the following to thercsetup.pyi file (Should be in roughly the same order as the.py file):

defvalidate_marker(s:Any)->int|string: ...defvalidate_markerlist(s:Any)->list[int|string]: ...
faisal-fawad reacted with thumbs up emoji

@tacaswelltacaswell added this to thev3.9.0 milestoneJan 9, 2024
Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

test failures unrelated

@story645
Copy link
Member

@faisal-fawad we typically prefer changes be squashed down to a few commits - would you have interest in squashing down to 1 commit or would you like us to do so?

@faisal-fawad
Copy link
ContributorAuthor

@story645 If you could handle it for this PR that would be preferred.

If you don't mind me asking, how could I squash the commits myself for future PRs?

@story645
Copy link
Member

https://matplotlib.org/devdocs/devel/development_workflow.html#rewrite-commit-history

faisal-fawad reacted with heart emoji

@QuLogic
Copy link
Member

There are a few extra changes here; make sure you usea force push after rebasing.

faisal-fawad and story645 reacted with thumbs up emoji

Add testAdd stubsPrivate functions & updated testUpdate testCo-authored-by: Kyle Sunden <git@ksunden.space>Add testPrivate functions & updated test
@QuLogic
Copy link
Member

Thanks@faisal-fawad! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

faisal-fawad reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@story645story645story645 approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Markers with numeric name like CARETLEFT cannot be specified using a cycler
5 participants
@faisal-fawad@ksunden@story645@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp