Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate cm#27579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Deprecate cm#27579
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tions, moved code to pyplot from cm
…ved functions, moved code to pyplot from cm"This reverts commita8a4f7f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
This is currently failing tests/linting, which will need to be fixed first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does not pass linting or tests.
| @@ -143,6 +142,10 @@ | |||
| _log = logging.getLogger(__name__) | |||
| _colormaps = ColormapRegistry(_gen_cmap_registry()) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This didn't need to move here AFAICT.
| @@ -32,22 +32,127 @@ matplotlib.ticker.LogitLocator.nonsingular | |||
| matplotlib.backend_bases._Mode.__new__ | |||
| matplotlib.units.Number.__hash__ | |||
| # Property read-write vs read-only weirdness, fix if possible | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The additions in this file seem unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These look like they are an older version of this file being reintroduced
PR summary
This PR includes the rebase and builds on top of andcloses#26965 with@UFEddy 's changes.
Please review carefully.
PR checklist