Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove 3.7-deprecated fontconfig api#27574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR - I've left a request to update the test intsead of removing it. Otherwise looks 👍
| def test_fontconfig_unknown_constant(): | ||
| with pytest.warns(DeprecationWarning): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Instead of deleting this test, could you change the warning check to an error check? That way we can make sure the error is raised as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For sure, I'll do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've added the test, please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great! Could whoever merges this do a squash merge?
Uh oh!
There was an error while loading.Please reload this page.
| @@ -1,7 +1,7 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sincepytest is a third party library, it was above the matplotlib import followingthe PEP8 style guide so ideally it should stay there.
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The correct fix is at#26884.
@bawejahritik Thanks for your interest, however we have merged the older pull request that included changes from related comments for this deprecation. We hope to hear from you again! |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Removal of old and unused API that were marked as deprecated in 3.7 of Matplotlib and the corresponding test.
(issue#26865)
PR checklist