NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Added test for tricontour#27545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

szhukovska wants to merge1 commit intomatplotlib:mainfromszhukovska:main

Closed

Added test for tricontour#27545

szhukovska wants to merge1 commit intomatplotlib:mainfromszhukovska:main

Conversation

Copy link

szhukovska commentedDec 19, 2023

PR summary

Added 3 tests for tricontour (issue#26864): datetime on y only, on x only and on x and y axes

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

tricontour test added

9c733e6

github-actionsbot reviewed

Dec 19, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link

Member

ksunden commentedDec 19, 2023

Thank you for your interest in improving Matplotlib!

However, this portion of that issue has already received a PR (#27494).
In general, barring significant technical advantages, we tend to prefer to give the first author to open a PR the opportunity to finish their contribution.

And in looking into it we discovered that thetri* plots are not actually properly handling unit-ful inputs, so we raised#27499. Your plot is hiding these failures because it a) callsplot so the axis units get set, when they are not properly set bytricontour alone (but should be) and b) happen to "work" because they usedatetime64[D] dtype which coincides with matplotlib's floating point representation of dates for axes, but it does not actually pass through the units code so if you used a different scale (e.g.datetime64[s]) then you would get the wrong thing plotted. (or indeed changed the epoch date for mpl from 1970-01-01)