Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make zdir key-word only for 3D-scatter and -bar#27538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -2590,8 +2590,8 @@ def add_collection3d(self, col, zs=0, zdir='z'): | ||
@_preprocess_data(replace_names=["xs", "ys", "zs", "s", | ||
"edgecolors", "c", "facecolor", | ||
"facecolors", "color"]) | ||
@_api.make_keyword_only("3.9", "zdir") | ||
def scatter(self, xs, ys, zs=0, zdir='z', s=20, c=None, depthshade=True, **kwargs): | ||
""" | ||
Create a scatter plot. | ||
@@ -2653,7 +2653,7 @@ def scatter(self, xs, ys, zs=0, zdir='z', s=20, c=None, depthshade=True, | ||
if np.may_share_memory(zs_orig, zs): # Avoid unnecessary copies. | ||
zs = zs.copy() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Here and below at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. In theory yes:https://matplotlib.org/devdocs/api/_as_gen/matplotlib.axes.Axes.scatter.html#matplotlib.axes.Axes.scatter but very unlikely in practice. One would have to pass all 3D positional parameters
and then continue with the non-overlapping 2D positional parameters, minimally:
I would be very surprised if somebody took the effort to figure that out. I'm inclined to allow tolerate minimal breakage here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Works for me! | ||
patches = super().scatter(xs, ys, s=s, c=c, **kwargs) | ||
art3d.patch_collection_2d_to_3d(patches, zs=zs, zdir=zdir, | ||
depthshade=depthshade) | ||
@@ -2667,7 +2667,8 @@ def scatter(self, xs, ys, zs=0, zdir='z', s=20, c=None, depthshade=True, | ||
scatter3D = scatter | ||
@_preprocess_data() | ||
@_api.make_keyword_only("3.9", "zdir") | ||
def bar(self, left, height, zs=0, zdir='z', **kwargs): | ||
""" | ||
Add 2D bar(s). | ||
@@ -2694,7 +2695,7 @@ def bar(self, left, height, zs=0, zdir='z', *args, **kwargs): | ||
""" | ||
had_data = self.has_data() | ||
patches = super().bar(left, height, **kwargs) | ||
zs = np.broadcast_to(zs, len(left), subok=True) | ||